ChunkedCons chunk-next returns empty seq instead of nil

Question

There is a bug in ChunkedCons. In Clojure ChunkedCons (correctly) always calls {{seq}} in chunked-next. In CLJS it's not done. But since ChunkedCons has to be lazy it pretty much always gets an (empty) lazy seq as the "more" part.

Bug:

`
(-> (map inc (vec (range 64)))

seq
chunk-next
seq
chunk-next)

`

Returns and empty sequence instead of nil. This hasn't surfaced yet since nothing calls chunk-next on a ChunkedCons (yet).

Answer 1

Comment made by: aralo

Found another bug that surfaced: Current implementation calls {{-seq}} on {{more}} which could be nil and this would blow up. So the patch also make a tiny change to {{-next}} also just calling {{seq}} on {{more}}. Pretty straight forward.

Answer 2

Comment made by: dnolen

This patch needs a test.

Answer 3

Comment made by: aralo

Test's added.

Answer 4

Comment made by: mfikes

patch does not apply

Answer 5

Comment made by: aralo

Patch rebased

Answer 6

Comment made by: mfikes

Patch no longer applies.

Answer 7

Reference: https://clojure.atlassian.net/browse/CLJS-2469 (reported by aralo)