Welcome! Please see the About page for a little more info on how this works.

0 votes
in ClojureScript by

Port CLJ-2417 to ClojureScript.

6 Answers

0 votes
by

Comment made by: namenu

My first contribution to CLJS.

And yes I've submitted CA and passed tests.

0 votes
by

Comment made by: mfikes

Thanks for the contribution!

Can you instead attach a patch formatted using the instructions at https://clojurescript.org/community/patches

0 votes
by

Comment made by: namenu

Sorry to bother you.

Here's a new patch.

0 votes
by

Comment made by: mfikes

CLJS-2959.patch LGTM, passes CI and Canary.

0 votes
by

Comment made by: thegeez

CLJS-2959-2.patch updates CLJS-2959.patch to name the test case after the CLJS issue number, instead of the CLJ issue number.

0 votes
by
Reference: https://clojure.atlassian.net/browse/CLJS-2959 (reported by mfikes)
...