Should print-table should use print-str rather than str on values?

Question

clojure.pprint/print-table calls str on the 'cols', should that really be print-str so print-method can be respected?

Answer 1

Do you have a specific example where you're not seeing what you expect?

Comments

In the following transcript, we have a defmethod for ZonedDateTime ignored by print-table but used by print-table2  which uses (print-str col)  and not (str col)

;; hide timezone location
(defmethod print-method java.time.ZonedDateTime
  [v ^java.io.Writer w]
  (.write w "#inst \"")
  (.write w (.format v java.time.format.DateTimeFormatter/ISO_OFFSET_DATE_TIME))
  (.write w "\""))
=> #object[clojure.lang.MultiFn 0x7a030531 "clojure.lang.MultiFn@7a030531"]

(clojure.pprint/print-table [{:a (java.time.ZonedDateTime/now)}])

|                                              :a |
|-------------------------------------------------|
| 2021-04-17T20:55:56.794+12:00[Pacific/Auckland] |
=> nil

(print-table2 [{:a (java.time.ZonedDateTime/now)}])

|                                              :a |
|-------------------------------------------------|
|           #inst "2021-04-17T20:56:48.715+12:00" |

Answer 2

Logged as https://clojure.atlassian.net/browse/CLJ-2650