memoization of js-dependency-index and get-upstream-deps needs knobs

Question

knobs should be exposed for more dynamic compilation environments like Figwheel which may desire to add dependencies to the classpath on the fly.

Answer 1

Comment made by: bhauman

A patch that caches upstream dependencies in the compiler env.

Answer 2

Comment made by: bhauman

Actually I'm going to submit another patch that includes the memoize calls in js-deps.

Answer 3

Comment made by: bhauman

New patch that moves {{cljs.js-deps}} memoization to current * } as well as {{get-upstream-deps}}.

Unfortunately there is a circular dep between {{cljs.env}} and {{cljs.js-deps}}, if we want to cache in * }. I overcame this with a resolve.

Compile performance is either completely unchanged or slightly improved based on several test runs.

Answer 4

Comment made by: bhauman

Hold off on this. Its not behaving as expected. Doesn't seem to be caching in certain situations.

Answer 5

Comment made by: dnolen

Thanks for the update. This will definitely not land until after the pending REPL/piggieback release anyhow.

Answer 6

Comment made by: bhauman

Yeah there is an obvious bug and a subtle one. Hopefully will finish it up soonish.

Answer 7

Comment made by: bhauman

Alright, this latest patch works. There was a subtle memoizing nil value bug.

Answer 8

Comment made by: mfikes

Patch no longer applies.

Answer 9

Reference: https://clojure.atlassian.net/browse/CLJS-1141 (reported by dnolen)