Make utility fn vars in cljs.spec.test.alpha private

Question

These utility fns in {{cljs.spec.test.alpha}} weren't intended for public use: {{distinct-by}}, {{get-host-port}}, {{get-ua-product}}, {{get-env}}

Answer 1

Comment made by: julioberina

Here's the patch for this issue

Answer 2

Comment made by: mfikes

Hey Julio, have you signed the CA? (I don't see your name listed here https://clojure.org/community/contributors)

If not, see https://clojurescript.org/community/contributing

Answer 3

Comment made by: julioberina

Yes. I have signed the CA since September 5. From what I saw online, it takes like a couple of months to update the contributor list

Answer 4

Comment made by: mfikes

Thanks, Julio. Your patch is probably fine. One aspect to consider is that {{defn-}} is typically used instead of private meta.

Answer 5

Comment made by: julioberina

I initially thought of doing that because I thought it was the other way around (private meta over defn-). Thank you for letting me know. I'll remember that for next time.

Answer 6

Comment made by: mfikes

CLJS-2849.patch LGTM and passes tests.

Answer 7

Reference: https://clojure.atlassian.net/browse/CLJS-2849 (reported by mfikes)