re-matches might give false negative when using match groups

Question

Current behaviour:

(re-matches #"(a|aa)" "aa") => nil

Expected:

(re-matches #"(a|aa)" "aa") => ["aa" "aa"]

JVM version works as expected, only CLJS is affected

Answer 1

Comment made by: dnolen

This is the kind of ticket that tends to break existing code. We should get some people who are interested in this ticket to actually try it out.

Answer 2

Comment made by: mfikes

FWIW, I gave cljs-1458-re-matches-might-give-false-negative.patch a try in bootstrapped ClojureScript and it is working fine there (each of the additional unit tests produce the expected results in bootstrapped).

Answer 3

Comment made by: mfikes

Patch no longer applies.

Answer 4

Comment made by: tonsky

New patch

Answer 5

Comment made by: mfikes

CLJS-1458-re-matches-might-give-false-negative-2.patch added to Patch Tender (i)

Answer 6

Reference: https://clojure.atlassian.net/browse/CLJS-1458 (reported by tonsky)