go ignores async code in letfn body

Question

The following snippet fails because <! is outside of {{go}} boundaries.

`
(let [port (a/chan)]
(a/go

(letfn [(my-even? [n] (if (zero? n) true (my-odd? (dec n))))
        (my-odd? [n] (if (zero? n) false (my-even? (dec n))))]
  (my-even? (a/<! port)))))

`

Async code in {{letfn}} body should be rewritten by the {{go}} macro, given all bound functions can be properly initialized when the body starts.

Answer 1

Comment made by: bronsa

Removing bad patch

Answer 2

Comment made by: alexmiller

What's the status on this? 0001-ASYNC-221-handle-letfn-in-ioc+test.patch is the patch?

Answer 3

Comment made by: leonoel

No, the fix and the test are both wrong.
The fix doesn't properly establishes circular references and the test fails to check it because it shadows clojure.core's odd?/even?.

Answer 4

Comment made by: leonoel

Updated example to properly check circular references

Answer 5

Reference: https://clojure.atlassian.net/browse/ASYNC-221 (reported by leonoel)