Implement abs, round for additional number types (patch attached)

Question

clojure.algo.generic.math-functions/abs did not work on:
clojure.lang.Ratio
clojure.lang.BigInt
java.math.BigDecimal
java.math.BigInteger
I defined defmethods for these classes, plus one for java.lang.Number to preserve the previous functionality for other number classes.

clojure.algo.generic.math-functions/round did not work on
clojure.lang.Ratio
clojure.lang.BigInt
java.math.BigDecimal
java.math.BigInteger
the various java integer classes (why shouldn't round work on integers?)
I defined defmethods to delegate java.Math.round for double and float, to act as the identity on the various integer classes, to delegate to java.math.BigDecimal#round for BigDecimal, and to cast Ratio to either a double or a BigDecimal and round it.

Answer 1

Comment made by: seancorfield

I've reminded Cort that he needs to get a signed CA on file for the patch to be used.

Answer 2

Comment made by: seancorfield

Looks like the patch is not compatible with Clojure 1.2: http://build.clojure.org/job/algo.generic-test-matrix/137/

Several Contrib projects are dropping support for 1.2 now so that's a reasonable choice if you don't want to modify the code.

Answer 3

Comment made by: spellman

Looks like BigInt was introduced in Clojure 1.3: https://github.com/clojure/clojure/commits/master/src/jvm/clojure/lang/BigInt.java

What do y'all think the good approach is?

Answer 4

Comment made by: spellman

I get passing tests under Clojure 1.2 when I comment out the BigInt stuff.

I tried

    *  conditionally making defmethods for BigInt based on the Clojure minor version
    *  putting the defmethods for BigInt inside of a try

In either case I get a ClassNotFoundException.

How would y'all do this?

Answer 5

Comment made by: spellman

New patch (off of master, NOT off of the first patch). I'm seeing the tests pass under Clojure 1.2 - 1.7.
Tests fail for 1.1 - the error says clojure.core/spit is not defined.

I conditionally made the defmethods for BigInt by using java.lang.Class/forName to check whether BigInt exists. I used eval for the abs defmethod; round didn't need it.

I don't know if this is idiomatic and I'd welcome an improvement :)
I tried a combination of java.lang.Class/forName and .getMethod but couldn't get it working.

Hope this helps!

Answer 6

Reference: https://clojure.atlassian.net/browse/ALGOG-12 (reported by spellman)