clojure.spec/Spec implementations that don't implement IObj get silently dropped in s/def

Question

`
(deftype MySpec []
s/Spec
(conform* [_ x]

::s/invalid))

(s/def ::x (MySpec.))

(s/explain ::x :foo)
`

This will fail with a "Unable to resolve spec: :user/x" exception, but the {{def}} succeeded. Switching the deftype to defrecord fixes the problem.

Cause: The {{with-name}} function has cond options for ident?, regex?, and IObj. If none of these succeed, there is no fallthrough case and the s/def will silently return nil.

Proposed: Throw an error in the fallthrough case.

Patch: clj-2135.patch

Answer 1

Reference: https://clojure.atlassian.net/browse/CLJ-2135 (reported by thheller)