core.unify run-tests.sh file has an error

Question

Two issues:
- there is no artifact called 1.11.0-master-SNAPSHOT
- it uses -A to invoke with main-opts

❯ ./run-tests.sh

[valid output]
...
Error building classpath. Could not find artifact org.clojure:clojure:jar:1.11.0-master-SNAPSHOT in central (https://repo1.maven.org/maven2/)

real	0m1.932s
user	0m2.018s
sys	0m0.132s

and

WARNING: Use of :main-opts with -A is deprecated. Use -M instead.

Running tests in #{"src/test/clojure"}

Testing with Clojure 1.10.1

Testing clojure.core.unify-test

Ran 12 tests containing 51 assertions.
0 failures, 0 errors.

The following patch quickly fixes both

diff --git a/deps.edn b/deps.edn
index d87033c..4d96956 100644
--- a/deps.edn
+++ b/deps.edn
@@ -7,7 +7,8 @@
            :1.8 {:override-deps {org.clojure/clojure {:mvn/version "1.8.0"}}}
            :1.9 {:override-deps {org.clojure/clojure {:mvn/version "1.9.0"}}}
            :1.10 {:override-deps {org.clojure/clojure {:mvn/version "1.10.1"}}}
-           :master {:override-deps {org.clojure/clojure {:mvn/version "1.11.0-master-SNAPSHOT"}}}
+           :1.11 {:override-deps {org.clojure/clojure {:mvn/version "1.11.1"}}}
+           :1.12 {:override-deps {org.clojure/clojure {:mvn/version "1.12.0"}}}
            :runner
            {:extra-deps {com.cognitect/test-runner
                          {:git/url "https://github.com/cognitect-labs/test-runner"
diff --git a/run-tests.sh b/run-tests.sh
index d0674d4..198907a 100755
--- a/run-tests.sh
+++ b/run-tests.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 
-versions="1.6 1.7 1.8 1.9 1.10 master"
+versions="1.6 1.7 1.8 1.9 1.10 1.11 1.12"
 for v in $versions
 do
-  time clj -A:test:runner:$v
+  time clj -M:test:runner:$v
 done

Answer 1

Fixed. Thanks for the heads up. I used 1.11.4 and updated :1.10 to 1.10.3.

Comments

Related to that, I think we can stop testing against 1.6. Thoughts?

---

I'd drop 1.6 and 1.7 -- and depending on what the State of Clojure 2024 shows, maybe 1.8 as well at this point.

---

I think we'll find overwhelming support from the survey to drop 1.6 and 1.7 and compelling support for dropping 1.8.

---

I figured (hoped) that might be the case :)

---

I think I'd like to immediately remove 1.6 because it doesn't support David Nolen's patch. We can circle back around on the others after the survey results land.

---

I only changed the deps.edn file -- the CI matrix file will need changing to drop 1.6 testing for real, right?

---

I think so yes.

---

The core CI matrix for contrib projects tests 1.9, 1.10, 1.11, and as of an hour or so ago, 1.12. And it runs those tests on JDK 8, 11, 17, and 21. Any deps.edn and testing scripts in those repos are purely for devs to test stuff -- CI only uses mvn with those Clojure/JDK versions.