Sub-optimal coding technique in clojure.tools.analyzer.utils ?

Question

Nearly nine years ago, when making tools.analyzer cross-platform (JVM/CLR), we did not yet have reader conditionalization. Leading to this bit of inelegance:

https://github.com/clojure/tools.analyzer/blob/726ab4f085f00c1c03f564dec359d50362efc846/src/main/clojure/clojure/tools/analyzer/utils.clj#LL81C1-L95C1

The commit actually has the comment "until we have feature expressions".

(- Since there needs to be question -): Isn't time to get rid ourselves of the affliction of throwing an exception to detect the platform and convert to reader conditionalization?

If there is Jira issue, I can submit a patch.

Answer 1

If you want to make a ticket in jira in https://clojure.atlassian.net/browse/TANAL and drop a patch, happy to take a look and merge

Comments

I will do so. Thanks.

---

Wouldn't a `regex?` predicate in core be an alternative?

---

It is an alternative, but implementing a new core function common to multiple platforms is going to take a lot longer.