Question

log/info removes quotes from strings making debugging harder than it needs to be.  I found that {:test1 "", :test2 "2"} is logged as {:test1  , :test2 2}.  I see the same issue when I print a map using println.  prn prints the map with the quotes which is better for debugging.

I will make a patch and add it later.

Answer 1

Comment made by: llsouder

Retested with 0.4.0

user=> (log/info ["test" "1" "" "3"]) Jul 23, 2017 8:22:56 AM user invoke INFO: [test 1 3] user=> (log/info ":one" :one 1 "1") Jul 23, 2017 8:35:30 AM user invoke INFO: :one :one 1 1

Output should be:

INFO: ["test" "1" "" "3"]

and

INFO: [":one" :one 1 "1"]

Answer 2

Comment made by: llsouder

Replace print-str with prn-str so user can see what will be evaluated. This is useful in debugging programs but I can see how this may mess up human readable info output out there in the wild.

Answer 3

Comment made by: tangrammer

Hi guys, I could avoid this annoying problem adding overwriting print-method for String type in my app code ... is it a convenient approach?

`
(defmethod clojure.core/print-method String

 [s ^java.io.Writer writer]

(.write writer (str "\"" s "\"")))
`

Answer 4

Comment made by: ilmoraunio

Attached is an alternative fix to the already proposed TLOG20.patch, where we use pr-str instead. This changeset allows for logged Clojure code to be compiler compliant when copypasted into a REPL (for example). The changeset affects the usage of logp and its derivatives.

This fix is necessary for easier debugging of production problems and, particularly, when a Clojure data entity is too large to do quote insertions manually.

Answer 5

Comment made by: clojure32647908

https://github.com/clojure/tools.logging/pull/11#issuecomment-388584804

https://github.com/xingzhefeng/tools.logging

Answer 6

_Comment made by: ataggart_

Despite the examples given, many real-world log entries contain not only structured data, but also human-readable explanatory text.  As such, switching to always using `pr-str` will emit quotes and escaped characters when _not_ desired, and with no way to work around it (unlike how one can work around the current issue by manually wrapping values with `pr-str`). This kind of breaking change is a no-go.

That said, it may be reasonable to add _new_ macros to handle this common point of friction.

A variant of `logp` is problematic since in the common case of mixing text and data we can’t know for certain which args the user intends to be treated which way.

A variant of `logf` might work, whereby all format args are mapped over `pr-str`, with explanatory text residing in the format string.

Answer 7

Reference: https://clojure.atlassian.net/browse/TLOG-20 (reported by llsouder)