Eliminate several uses of reflection in java.jmx

Question

There are a fair number of occurrences of reflection in java.jmx that can be eliminated with the addition of suitable type hints.

Answer 1

Comment made by: jafingerhut

jmx-9-eliminate-reflection-v1.txt dated Oct 28 2012 eliminates most reflection warnings from java.jmx.

I would recommend that you check the type hints carefully before applying this, in case I messed some of them up. I am not familiar with javax.management library usage. I simply did a lot of looking at method signatures for methods used in the code in the Java library docs.

In particular, I wasn't sure whether connection should be a javax.management.MBeanServer or MBeanServerConnection. MBeanServerConnection is good enough for most of the code, but for the .registerMBean method invocation in register-mbean it needs to be a MBeanServer to avoid reflection. Perhaps it should be MBeanServer everywhere? My main question is whether that would limit the code's generality too much.

Answer 2

Comment made by: nickmbailey

Well it shouldn't be MBeanServer everywhere. When using the with-connection macro connection is a RemoteMBeanServerConnection and 'registerMBean' isn't a defined method.

I'm thinking perhaps we just change register-mbean to always get the local JMX server rather than using the connection binding. You can't register mbeans with a remote jmx server.

Answer 3

Comment made by: stu

Sorry, I saw this only after completing a similar (and inferior) change. The 0.3.3 maven release eliminates reflection warnings and punts on changing register-mbean. (The latter change seems fine to me, but I was trying to do one thing at a time).

Let me know if this has broken anything.

Answer 4

Reference: https://clojure.atlassian.net/browse/JMX-9 (reported by jafingerhut)