Welcome! Please see the About page for a little more info on how this works.

0 votes
in ClojureScript by

The {{cljs.core/divide}} inlining macro was introduced to work around an inability to specify {{cljs.core//}}.

For example: https://github.com/clojure/clojurescript/blob/d45012273029bd5df3973ea716394f368e1c44cc/src/main/cljs/cljs/core.cljs#L2593

This can now evidently be removed and thus avoid things like CLJS-594 and {{divide}} showing up as a completion in IDEs, etc.

5 Answers

0 votes
by

Comment made by: mfikes

CLJS-2409-2.patch adds unit tests.

0 votes
by

Comment made by: mfikes

Adding re-baselined patch.

0 votes
by

Comment made by: mfikes

Adding rebaselined patch.

0 votes
by

Comment made by: mfikes

When applied to current master, tests fail with

ERROR in (test-cljs-2409) (Error:NaN:6) expected: (== 2 (apply / [6 3])) actual: #object[Error Error: No protocol method Slashy./ defined for type number: 6]

0 votes
by
Reference: https://clojure.atlassian.net/browse/CLJS-2409 (reported by mfikes)
...