empty? is broken for transient collections

Question

Like CLJ-1872 but for ClojureScript. (Note that CLJ-1872 is vetted, targeting Clojure 1.10.)

ClojureScript 1.10.339 cljs.user=> (empty? (transient [])) ... Error: [object Object] is not ISeqable ... cljs.user=> (empty? (transient {})) ... Error: [object Object] is not ISeqable ... cljs.user=> (empty? (transient #{})) ... Error: [object Object] is not ISeqable ... cljs.user=>

Answer 1

_Comment made by: mfikes_

Adds an additional check for {{ITransientCollection}} in {{empty?}} implementation and delegates to {{count}}, which should be O(1).

It may be worth waiting to see if CLJ-1872 actually ships in Clojure before applying. (This would also afford an opportunity to make the docstring match Clojure's.)

Answer 2

Comment made by: mfikes

CLJS-2802-2.patch rebaselines

Answer 3

Comment made by: mfikes

CLJS-2802-2.patch added to Patch Tender (i)

Answer 4

Comment made by: dnolen

Lowering the priority on this as the verdict for the same change in Clojure is uncertain.

Answer 5

Reference: https://clojure.atlassian.net/browse/CLJS-2802 (reported by mfikes)