Welcome! Please see the About page for a little more info on how this works.

0 votes
in core.async by

ASYNC-169 addresses many try/catch/finally in go block issues on the Clojure side and should be ported to cljs side as well.

6 Answers

0 votes
by

Comment made by: hiredman

I am not 100% on how all the clojurescript stuff works, but it looks like the tests in runner_tests.cljs weren't being run (via the cljsbuild and loading up runtests.html). 0001-ASYNC-184-actually-run-the-runner-tests.patch causes those tests to be run

0 votes
by

Comment made by: hiredman

0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch is a port of the clojure exception fixes in ASYNC-169 to clojurescript, includes some tests based on other cljs core.async issues

0 votes
by

Comment made by: hiredman

I updated 0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch to fix ASYNC-198 on the cljs side

0 votes
by

Comment made by: hiredman

0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch updated to have better exceptions when a try/catch/finally is malformed

0 votes
by

Comment made by: hiredman

may needed updating for ASYNC-220 on the cljs side

0 votes
by
Reference: https://clojure.atlassian.net/browse/ASYNC-184 (reported by alexmiller)
...