https://ask.clojure.org/index.php/unanswered/contrib-libs/core-match https://ask.clojure.org/index.php/9909/can-core-match-literalpattern-emit-more-specialized-code <p>Hello,<br> Looking at the code emitted by core.match, I see that literals are always compared using <code>=</code>. <br> While it works, wouldn't it be faster to specialize equality for different literals, such as:</p> <pre><code> (number? l) `(and (number? ~ocr) (== ~l ~ocr)) (keyword? l) `(identical? ~l ~ocr) (nil? l) `(nil? ~ocr) (true? l) `(true? ~ocr) (false? l) `(false? ~ocr) (string? l) `(.equals ~l ~ocr) </code></pre> <p>(snippet added to <code>LiteralPattern</code> cond.</p> <p>Crude benchmarks show it's faster than <code>=</code> and all the tests pass, too.</p> <p>Think this warrants a patch?</p> core.match https://ask.clojure.org/index.php/9909/can-core-match-literalpattern-emit-more-specialized-code Tue, 01 Dec 2020 07:29:48 +0000